CustomMencoderOptions ignored (on Renderer level)

Discuss issues related to PS3 Media Server development (only for programmers)

CustomMencoderOptions ignored (on Renderer level)

Postby ExSport » Mon Dec 10, 2012 11:46 am

I found the bug why from some version until now "CustomMencoderOptions" is ignored.
From older post:
Code: Select all
"CustomMencoderOptions=-vf softskip,expand=::::1:16\/9:4" in Renderer.conf is ignored or replaced so it is not added as MEncoder param.

https://github.com/ps3mediaserver/ps3me ... java#L1419
Code: Select all
if (rendererMencoderOptions.contains("expand=") || dvd) {
   rendererMencoderOptions = null;
}

We should use "&&" instead of "||" :idea:
ExSport
 
Posts: 2167
Joined: Mon Jan 19, 2009 5:40 pm

Re: CustomMencoderOptions ignored (on Renderer level)

Postby ExSport » Tue Dec 11, 2012 12:10 am

ExSport
 
Posts: 2167
Joined: Mon Jan 19, 2009 5:40 pm

Re: CustomMencoderOptions ignored (on Renderer level)

Postby Raptor399 » Wed Dec 26, 2012 12:46 pm

ExSport wrote:We should use "&&" instead of "||" :idea:

I am not convinced of this, as commented on the pull request.

It appears to be a design choice for PMS to enforce its own "expand=" behavior over that of custom mencoder options.
Personally, I don't know the reasoning behind it, but feel free to challenge that design choice.
Because if that changes, in its wake other pieces of code may need some adjustment as well.
Raptor399
Project Member
 
Posts: 1916
Joined: Thu Mar 10, 2011 12:06 am


Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests