PMS SubJunk Build

[SubJunk]

It should also be noted that all versions work perfectly for me so don't just assume that this bug will affect you, it may only affect certain CPUs. We will know more soon

[Junkyboy]

Hi. Thanks for all the work with your version of PMS. I just wanted to pass along a couple of notes: On OSX, the ffmpeg, mencoder, and mplayer binaries are failing with "Illegal Instruction : 4" for me running Lion 10.7.3 (on several different macs, all retrieved using maven). My copies compiled with homebrew work fine.
In order for me to play any of my anime mkv with ASS subtitles with -ass enabled and using the style the comes with the file, I find I have to alter the source a bit. In MEncoderVideo.java, params.sid.isFileUtf8() (one of the tests to enable -ass for mencoder) is always false for my files. Going through the code I found this:

Code: Select all

public static void getSubCodec(DLNAMediaSubtitle subt, String value) {
    if (value.equals("s_text/ass") || value.equals("s_text/ssa")) {
        subt.setType(DLNAMediaSubtitle.ASS);
    } else if (value.equals("pgs")) {
        subt.setType(-1); // PGS not yet supported
    } else if (value.equals("s_text/utf8")) {
        subt.setType(DLNAMediaSubtitle.EMBEDDED);
        subt.setFileUtf8(true);
    }
}

Seems like a "subt.setFileUtf8(true);" should be there for ass/ssa as well since its specifically tested for in the ASS enabling code. I added it..and it didnt help for some reason, still false. Well I just commented out the test and it started to emit the -ass flag. Then I noticed I could not turn off style override, regardless of the button selection. Looking at the code I found this:

Code: Select all

// GUI: Override ASS subtitles style if requested (always for SRT subtitles)
if (
     !configuration.isMencoderAssDefaultStyle() ||
     params.sid.getType() == DLNAMediaSubtitle.SUBRIP ||
     params.sid.getType() == DLNAMediaSubtitle.EMBEDDED
) {

Well, all of my mkvs with subtitles are DLNAMediaSubtitle.EMBEDDED and I wanted to use the style it comes with. So, I comment out params.sid.getType() == DLNAMediaSubtitle.EMBEDDED and it works perfectly. If I want to force the default style, I can just use the checkbox.
Thanks for the all the hard work, this is the best version of PMS released!

[happy.neko]

Seems like a "subt.setFileUtf8(true);" should be there for ass/ssa as well since its specifically tested for in the ASS enabling code. I added it..and it didnt help for some reason, still false. Well I just commented out the test and it started to emit the -ass flag. Then I noticed I could not turn off style override, regardless of the button selection. Looking at the code I found this:

Code: Select all

// GUI: Override ASS subtitles style if requested (always for SRT subtitles)
if (
     !configuration.isMencoderAssDefaultStyle() ||
     params.sid.getType() == DLNAMediaSubtitle.SUBRIP ||
     params.sid.getType() == DLNAMediaSubtitle.EMBEDDED
) {

Well, all of my mkvs with subtitles are DLNAMediaSubtitle.EMBEDDED and I wanted to use the style it comes with. So, I comment out params.sid.getType() == DLNAMediaSubtitle.EMBEDDED and it works perfectly. If I want to force the default style, I can just use the checkbox.
Thanks for the all the hard work, this is the best version of PMS released!

DLNAMediaSubtitle.SUBRIP = external SRT subtitles
DLNAMediaSubtitle.EMBEDDED = embedded SRT subtitles
DLNAMediaSubtitle.ASS = embedded SSA/ASS subtitles

At least that what I thought when I wrote SSA-styling patch in question. So your mkv should return DLNAMediaSubtitle.ASS for sub track, not DLNAMediaSubtitle.EMBEDDED. Can you upload small sample on mediafire?

[ExSport]

And what is returned for external ASS/SSA subs?

Code: Select all

DLNAMediaSubtitle.ASS ?

[Junkyboy]

Just get some more testing in, I added some more logging to MediaInfoParser (the class that sets the type to DLNAMediaSubtitle.ASS). I don't see it getting called since none of my added log messages are showing up. However, logs in MEncoderVideo are still showing :

DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] params.sid.isFileUtf8() : false
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] params.sid.getType() == DLNAMediaSubtitle.EMBEDDED : true
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] params.sid.getType() != DLNAMediaSubtitle.EMBEDDED : false
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] params.sid.getType() != DLNAMediaSubtitle.VOBSUB : true
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] params.sid.getType() == DLNAMediaSubtitle.SUBRIP : false
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] media.getContainer().equals("mp4") : false
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] configuration.isMencoderAss() : true
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] foundNoassParam : false
DEBUG 2012-03-30 09:51:14.341 [New I/O server worker #1-6] dvd : false

If MediaInfoParser is not getting called, that would explain why my first change at setting isFileUtf8(true) at

Code: Select all

public static void getSubCodec(DLNAMediaSubtitle subt, String value) {
    logger.debug("getSubCodec : value is : " + value);  // never gets printed for me
    if (value.equals("s_text/ass") || value.equals("s_text/ssa")) {
        subt.setType(DLNAMediaSubtitle.ASS);
        subt.setFileUtf8(true); // should this be here? Its required to enable -ass
    } else if (value.equals("pgs")) {
        subt.setType(-1); // PGS not yet supported
    } else if (value.equals("s_text/utf8")) {
        subt.setType(DLNAMediaSubtitle.EMBEDDED);
        subt.setFileUtf8(true);
    }
}

didnt change anything. I'll upload the file I've been using to test in a bit but its happened with any file I throw at it (mkv with embedded ass subs).

[happy.neko]

Just get some more testing in, I added some more logging to MediaInfoParser (the class that sets the type to DLNAMediaSubtitle.ASS). I don't see it getting called since none of my added log messages are showing up.

Check trace tab to see if mediainfo lib is loaded upon server startup and what version.

And what is returned for external ASS/SSA subs?

Code: Select all

DLNAMediaSubtitle.ASS ?

I don't remember now, but my guess is "yes".

[smo]

Is it just me or is the build broken? http://pms.smoeller.de/job/pms-subjunk% ... ld/console

smo

[Junkyboy]

INFO 2012-03-30 11:20:17.687 [main] Loading MediaInfo library
INFO 2012-03-30 11:20:17.747 [main] Loaded MediaInfoLib - v0.7.54

I checked the library with otool and its checks out ok.

[Elfy]

Just registered to say thanks for all your work.

[SubJunk]

SB69 is released, this version should hopefully fix the MEncoder issues with AC3 audio. Thanks ExSport for your help testing it!