[Patch] GUI: "Navigation/Share Settings"

Discuss issues related to PS3 Media Server development (only for programmers)

[Patch] GUI: "Navigation/Share Settings"

Postby smo » Fri Oct 07, 2011 5:03 pm

Hello,

I've created a patch that fixes some minor gui glitches. For better readability I've also refactored the code a bit..

Here are 2 screenshots to show the differences:
Before -> After

Edit: Just fixed another issue, updated patch is attached.

Regards,
smo
Attachments
NavigationShareTab.java.patch.zip
(3.2 KiB) Downloaded 77 times
smo
 
Posts: 46
Joined: Thu Nov 12, 2009 12:29 pm
Location: Germany

Re: [Patch] GUI: "Navigation/Share Settings"

Postby SubJunk » Fri Oct 07, 2011 10:54 pm

Thanks for the patch, but it causes a horizontal scrollbar for me which will prevent me from adding it to the codebase. Other than that it's good.
Attachments
ps3.png
Scrollbar
ps3.png (149.35 KiB) Viewed 1704 times
SubJunk
 
Posts: 1210
Joined: Fri Mar 27, 2009 5:25 am

Re: [Patch] GUI: "Navigation/Share Settings"

Postby smo » Sat Oct 08, 2011 12:15 am

In the patch included is already a change for messages.properties that solves the problem with the scrollbar.

However I'm not sure if it is ok to change the property. The problem is that I've played around with the code for some time and didn't manage to find another clean solution (besides resizing the whole application window..).
smo
 
Posts: 46
Joined: Thu Nov 12, 2009 12:29 pm
Location: Germany

Re: [Patch] GUI: "Navigation/Share Settings"

Postby SubJunk » Sat Oct 08, 2011 1:04 am

Please see the screenshot I posted, it already has the language change but still the scrollbar
SubJunk
 
Posts: 1210
Joined: Fri Mar 27, 2009 5:25 am

Re: [Patch] GUI: "Navigation/Share Settings"

Postby smo » Sat Oct 08, 2011 2:28 am

SubJunk wrote:Please see the screenshot I posted, it already has the language change but still the scrollbar


I'm sorry, you're right.

Seems that the problem occurs not on all jvm/os combinations (Working: linux+openjdk1.6.0_23, linux+openjdk1.7.0_147, WindowsXP+sun-jdk1.6.0_26-b03; Not working: linux+sun-jdk1.6.0_26-b03, Windows7+sun-jdk).

I'm going to take a closer look on it.
smo
 
Posts: 46
Joined: Thu Nov 12, 2009 12:29 pm
Location: Germany

Re: [Patch] GUI: "Navigation/Share Settings"

Postby smo » Tue Oct 11, 2011 12:32 am

About the horizontal scrollbars:
The last stable Windows build (1.40.0) is looking good in Windows, however at least in Linux (also 1.40.0) there are horizontal scrollbars in "Navigation" and "Transcode Settings".
Seems to be something about fonts and/or how "Dialog Units(dlu") are calculated by different VMs/OS. I'm not sure, so I've reverted my changes that have caused the horizontal scrollbar.

Please review the patch attached, the only changes should be about vertical alignment. I did a quick test with Windows 7 and it seems to be ok.

Regards,
smo
Attachments
NavigationShareTab.java.patch2.zip
(2.8 KiB) Downloaded 79 times
smo
 
Posts: 46
Joined: Thu Nov 12, 2009 12:29 pm
Location: Germany

Re: [Patch] GUI: "Navigation/Share Settings"

Postby SubJunk » Tue Oct 11, 2011 1:08 am

Looks great, I've applied it to the official trunk in r915. Good job.
SubJunk
 
Posts: 1210
Joined: Fri Mar 27, 2009 5:25 am


Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests