[Patch] GUI: "Navigation/Share Settings"

[smo]

Hello,

I've created a patch that fixes some minor gui glitches. For better readability I've also refactored the code a bit..

Here are 2 screenshots to show the differences:
Before -> After

Edit: Just fixed another issue, updated patch is attached.

Regards,
smo

[SubJunk]

Thanks for the patch, but it causes a horizontal scrollbar for me which will prevent me from adding it to the codebase. Other than that it's good.

[smo]

In the patch included is already a change for messages.properties that solves the problem with the scrollbar.

However I'm not sure if it is ok to change the property. The problem is that I've played around with the code for some time and didn't manage to find another clean solution (besides resizing the whole application window..).

[SubJunk]

Please see the screenshot I posted, it already has the language change but still the scrollbar

[smo]

Please see the screenshot I posted, it already has the language change but still the scrollbar

I'm sorry, you're right.

Seems that the problem occurs not on all jvm/os combinations (Working: linux+openjdk1.6.0_23, linux+openjdk1.7.0_147, WindowsXP+sun-jdk1.6.0_26-b03; Not working: linux+sun-jdk1.6.0_26-b03, Windows7+sun-jdk).

I'm going to take a closer look on it.

[smo]

About the horizontal scrollbars:
The last stable Windows build (1.40.0) is looking good in Windows, however at least in Linux (also 1.40.0) there are horizontal scrollbars in "Navigation" and "Transcode Settings".
Seems to be something about fonts and/or how "Dialog Units(dlu") are calculated by different VMs/OS. I'm not sure, so I've reverted my changes that have caused the horizontal scrollbar.

Please review the patch attached, the only changes should be about vertical alignment. I did a quick test with Windows 7 and it seems to be ok.

Regards,
smo

[SubJunk]

Looks great, I've applied it to the official trunk in r915. Good job.