New features (r750)

Discuss issues related to PS3 Media Server development (only for programmers)

New features (r750)

Postby ExSport » Thu Jul 14, 2011 7:44 am

Hi
Below you can find three patch files which adds:
- PartialContentRange support, see WoH #822: http://code.google.com/p/ps3mediaserver/issues/detail?id=822
- CustomMencoderOptions can be defined on renderer level
- Additional Audio/Subtitle Track Info
- Forced Subtitles support (now it can be configured in GUI / MEncoder page)
- Typo fixes, better audio sync for MEncoder, faster start of streaming on PS3, XBMC

Some tips are here: http://code.google.com/p/pms-exsport/wiki/FAQ
Patches are made for latest r750 version.
Any feedback welcome.
Edit:
Posted it to GoogleCode project here: https://code.google.com/p/ps3mediaserve ... il?id=1134
Attachments
PartialContentRange_r750.zip
PartialContentRange
(2.61 KiB) Downloaded 98 times
CustomMencoderOptions_AudioSubTags_ForcedSub_r750.zip
CustomMencoderOptions_AudioSubtitleTags_ForcedSubSupport
(4.85 KiB) Downloaded 103 times
Misc_r750.zip
Misc
(1.12 KiB) Downloaded 98 times
Last edited by ExSport on Thu Jul 14, 2011 9:39 am, edited 1 time in total.
ExSport
 
Posts: 2168
Joined: Mon Jan 19, 2009 5:40 pm

Re: New features (r750)

Postby SubJunk » Thu Jul 14, 2011 8:03 am

Great, I'll add it to the next SubJunk Build for testing. Thanks a lot :)
SubJunk
 
Posts: 1212
Joined: Fri Mar 27, 2009 5:25 am

Re: New features (r750)

Postby ExSport » Thu Jul 14, 2011 9:39 am

Great!
Thanks a lot 8-)
ExSport
 
Posts: 2168
Joined: Mon Jan 19, 2009 5:40 pm

Re: New features (r750)

Postby infidel » Fri Jul 22, 2011 12:56 am

One additional note for Sony bdp players:

WoH #822 fixes streaming of supported formats, but for transcoding we still need the Patters fix (see here, essentially it ensures that Content-Length and/or total length in Content-Range is always -1 when transcoding). This patch is safe for general usage and plays nicely with other renderers (activated by the line 'TranscodedVideoFileSize=370' in SonyBluray.conf) and maintains the ability to seek in supported formats when activated.

There's also Grolschie's patch (part of which evolved from an earlier hack of my own), but it hardcodes the transcoding fix and as a result disables seeking altogether and so isn't suitable for general use. On the plus side Grolschie reports achieving wider transcoding support than with the Patters fix.

Attached is the Woh/Patters combo patch for r750, with the fixes extended to Request V1 as well.
Attachments
PartialContentRange_transcoding.r750.zip
(4.09 KiB) Downloaded 93 times
Last edited by infidel on Fri Jul 22, 2011 11:50 am, edited 1 time in total.
infidel
 
Posts: 278
Joined: Sun Aug 15, 2010 4:56 pm

Re: New features (r750)

Postby SubJunk » Fri Jul 22, 2011 5:09 am

Just tried your patches ExSport and I get a compiling error:

Code: Select all
    [javac] net\pms\dlna\DLNAResource.java:1289: cannot find symbol
    [javac] symbol  : variable fis
    [javac] location: class net.pms.dlna.DLNAResource
    [javac]                     if(high > low && fis != null)
    [javac]                                      ^
    [javac] net\pms\dlna\DLNAResource.java:1294: cannot find symbol
    [javac] symbol  : variable fis
    [javac] location: class net.pms.dlna.DLNAResource
    [javac]                             fis = new SizeLimitInputStream(fis, bytes);
    [javac]                             ^
    [javac] net\pms\dlna\DLNAResource.java:1294: cannot find symbol
    [javac] symbol  : variable fis
    [javac] location: class net.pms.dlna.DLNAResource
    [javac]                             fis = new SizeLimitInputStream(fis, bytes);
    [javac]                                                            ^


Did you mean to put that WoH #822 code up under if (player == null) {, where the fis variable is used, instead of the else statement?
SubJunk
 
Posts: 1212
Joined: Fri Mar 27, 2009 5:25 am

Re: New features (r750)

Postby SubJunk » Fri Jul 22, 2011 6:02 am

I removed the bit of code I mentioned in my previous post and it compiled, but then when I tested it, all my MKV files had out of sync audio.
So I reverted the -mc 0.005 part and it was in sync again. So I can't recommend that change.
SubJunk
 
Posts: 1212
Joined: Fri Mar 27, 2009 5:25 am

Re: New features (r750)

Postby SubJunk » Fri Jul 22, 2011 7:22 am

Why do you think we need a GUI for forced subtitles? I think forced subtitles should always be enabled.
Also, I think the language additions are missing from the patches; MEncoderVideo.94 and MEncoderVideo.95
SubJunk
 
Posts: 1212
Joined: Fri Mar 27, 2009 5:25 am

Re: New features (r750)

Postby ExSport » Fri Jul 22, 2011 7:54 am

SubJunk wrote:Just tried your patches ExSport and I get a compiling error:

Please post your patched "DLNAResource.java". It works with official trunk, maybe patch applied in wrong way on your subjunk build?
Did you mean to put that WoH #822 code up under if (player == null) {, where the fis variable is used, instead of the else statement?

Code should be like this:
Code: Select all
      if (player == null) {
         if (this instanceof IPushOutput) {
            PipedOutputStream out = new PipedOutputStream();
            PipedInputStream fis = new PipedInputStream(out);
            ((IPushOutput) this).push(out);
            if (low > 0 && fis != null) {
               fis.skip(low);
            }
// WoH #822
            if(high > low && fis != null)
            {
               long bytes = (high - (low < 0 ? 0 : low)) + 1;
               
               logger.trace("Using size-limiting stream (" + bytes + " bytes)");
               SizeLimitInputStream slis = new SizeLimitInputStream(fis, bytes);
               return slis;
            }
// /WoH #822
            return fis;
         }

         InputStream fis = null;

I removed the bit of code I mentioned in my previous post and it compiled, but then when I tested it, all my MKV files had out of sync audio.
So I reverted the -mc 0.005 part and it was in sync again. So I can't recommend that change.

Very very strange. It should not be due -mc 0.005 parameter. Maybe it is due to wrongly patched file?
Please try to play same file and post used MEncoder command.Also you can try to edit this command by adding -mc 0.005 if it will make file out of sync. -mc 0 and -noskip have to be removed when -mc 0.005 is used.
You can also try my compilation if your files will be out of sync so we will know where is the problem(parameter or bad build).
I never found(never = about 500 files tested) that -mc.005 did something wrong, allways it helped because lot of movies has audio delay set or are wrongly encoded and this helped in all cases. Sure I didn't tested your new mencoder build with it, only with official trunk.
Also you can test my compilation: http://code.google.com/p/pms-exsport/do ... 1.31.0.exe
Also there is a chance that when I created .patch files I did mistake somewhere, it was quite early morning 8-)
Many thanks
ExSport
P.S.
Yes, it seems I forgot to upload messages.properties, I attached it below
Anyway please test my compiled version and if it works then maybe patch doesn't fit without additional changes for your special build or I did mistake when .diff/.patch file was created.
And yes, forced subs should be automatically enabled but I wanted to add it to GUI so normal user can easily enable/disable it without knowing something about conf editing and also will know about this new feature. But minimally you need gui for setting "forced sub tag and forced sub lang":)
Thx!!!
Attachments
messages.zip
english messages
(4.73 KiB) Downloaded 85 times
ExSport
 
Posts: 2168
Joined: Mon Jan 19, 2009 5:40 pm

Re: New features (r750)

Postby ExSport » Fri Jul 22, 2011 9:07 am

Sorry forced subs are enabled automatically but you need GUI for setting these 8-)
I was sleeping when answered your last question :mrgreen:
Attachments
forced_subs.png
Forced subs settings
forced_subs.png (36.2 KiB) Viewed 2619 times
ExSport
 
Posts: 2168
Joined: Mon Jan 19, 2009 5:40 pm

Re: New features (r750)

Postby pixelfougb » Sat Jul 23, 2011 1:45 pm

hello ExSport and all

I try your distrib and it's ok for my sony blue ray - no problems with the others devices like freebox,sony tv,frame picture kodak,streaming player philipps

i don't try subtittle but if you have a example , i can try it :mrgreen:

I have just a probleme with a file (synchro song/video). i suppose the file is corrupt. :?:

Can you give me your patch because i try to patch and i have an error on the build (r750+patch requestv2(viewtopic.php?f=15&t=6930&p=35877&hilit=patch#p35877)+PartialContentRange_transcoding.r750). :oops:

bests regards.
pixelfougb
 
Posts: 32
Joined: Fri Dec 03, 2010 7:08 pm
Location: France

Next

Return to Developers

Who is online

Users browsing this forum: No registered users and 2 guests