iTunes Library Scan Error

[owine]

I am getting errors with the iTunes library scan. Didn't use this feature before iTunes 10.5 came out so I do not know if it is related to the new release but here is the data from trace:

Code: Select all

[New I/O server worker #1-2] ERROR 14:48:00.416 Something went wrong with the iTunes Library scan:
java.lang.NullPointerException: null
   at net.pms.dlna.RootFolder.getiTunesFolder(RootFolder.java:628) [pms.jar:na]
   at net.pms.dlna.RootFolder.discoverChildren(RootFolder.java:129) [pms.jar:na]
   at net.pms.dlna.DLNAResource.discoverWithRenderer(DLNAResource.java:592) [pms.jar:na]
   at net.pms.dlna.DLNAResource.getDLNAResources(DLNAResource.java:534) [pms.jar:na]
   at net.pms.network.RequestV2.answer(RequestV2.java:558) [pms.jar:na]
   at net.pms.network.RequestHandlerV2.writeResponse(RequestHandlerV2.java:255) [pms.jar:na]
   at net.pms.network.RequestHandlerV2.messageReceived(RequestHandlerV2.java:225) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:148) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.handler.codec.http.HttpChunkAggregator.messageReceived(HttpChunkAggregator.java:116) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:302) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.unfoldAndfireMessageReceived(ReplayingDecoder.java:522) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:506) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:443) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:540) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:349) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:280) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:200) [pms.jar:na]
   at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) [pms.jar:na]
   at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:44) [pms.jar:na]
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [na:1.6.0_26]
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [na:1.6.0_26]
   at java.lang.Thread.run(Thread.java:680) [na:1.6.0_26]


Something with my configuration or something else? This is on 1.50.0 beta, but it does not work with 1.40.0 either. Same error.

[Raptor399]

That code hasn't changed in a long while. The NullPointerException indicates a problem with one of the files that was found, but I don't see any hints on what was wrong with it.
Fix committed in r961, thanks for the bug report!

[owine]

Seems an issue with the iTunes library has cropped up again. Seems to be similar to the previous one. Here's the trace.

Code: Select all

[New I/O server worker #1-2] ERROR 16:49:19.387 Something went wrong with the iTunes Library scan:
java.lang.NullPointerException: null
   at net.pms.dlna.RootFolder.getiTunesFolder(RootFolder.java:632) [pms.jar:na]
   at net.pms.dlna.RootFolder.discoverChildren(RootFolder.java:129) [pms.jar:na]
   at net.pms.dlna.DLNAResource.discoverWithRenderer(DLNAResource.java:725) [pms.jar:na]
   at net.pms.dlna.DLNAResource.getDLNAResources(DLNAResource.java:668) [pms.jar:na]
   at net.pms.network.RequestV2.answer(RequestV2.java:568) [pms.jar:na]
   at net.pms.network.RequestHandlerV2.writeResponse(RequestHandlerV2.java:290) [pms.jar:na]
   at net.pms.network.RequestHandlerV2.messageReceived(RequestHandlerV2.java:253) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:148) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.handler.codec.http.HttpChunkAggregator.messageReceived(HttpChunkAggregator.java:116) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:302) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.unfoldAndfireMessageReceived(ReplayingDecoder.java:522) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:506) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:443) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:540) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:349) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:280) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:200) [pms.jar:na]
   at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) [pms.jar:na]
   at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:44) [pms.jar:na]
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [na:1.6.0_29]
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [na:1.6.0_29]
   at java.lang.Thread.run(Thread.java:680) [na:1.6.0_29]

[Raptor399]

You're right, it is similar.
It has already been fixed in commit 6ce85d5435.

Thanks for reporting!

[astopy]

Did this bug fix get included in 1.50.1? Because I'm getting the same error:

Code: Select all

[New I/O server worker #1-4] ERROR 18:05:52.880 Something went wrong with the iTunes Library scan:
java.lang.NullPointerException: null
   at net.pms.dlna.RootFolder.getiTunesFolder(RootFolder.java:632) [pms.jar:na]
   at net.pms.dlna.RootFolder.discoverChildren(RootFolder.java:129) [pms.jar:na]
   at net.pms.configuration.RendererConfiguration.getRootFolder(RendererConfiguration.java:92) [pms.jar:na]
   at net.pms.PMS.getRootFolder(PMS.java:160) [pms.jar:na]
   at net.pms.network.RequestV2.answer(RequestV2.java:568) [pms.jar:na]
   at net.pms.network.RequestHandlerV2.writeResponse(RequestHandlerV2.java:290) [pms.jar:na]
   at net.pms.network.RequestHandlerV2.messageReceived(RequestHandlerV2.java:253) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:148) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.handler.codec.http.HttpChunkAggregator.messageReceived(HttpChunkAggregator.java:116) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:754) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:302) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.unfoldAndfireMessageReceived(ReplayingDecoder.java:522) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.callDecode(ReplayingDecoder.java:506) [pms.jar:na]
   at org.jboss.netty.handler.codec.replay.ReplayingDecoder.messageReceived(ReplayingDecoder.java:443) [pms.jar:na]
   at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:80) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:545) [pms.jar:na]
   at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:540) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:274) [pms.jar:na]
   at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:261) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:349) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.processSelectedKeys(NioWorker.java:280) [pms.jar:na]
   at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:200) [pms.jar:na]
   at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) [pms.jar:na]
   at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:44) [pms.jar:na]
   at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) [na:1.6.0_29]
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) [na:1.6.0_29]
   at java.lang.Thread.run(Thread.java:680) [na:1.6.0_29]

[Raptor399]

Nope, that commit isn't in PMS 1.50.1.

[astopy]

Thanks. Any idea when it's likely to make it into a release?

[Raptor399]

Thanks. Any idea when it's likely to make it into a release?

It will be in the next release.

[astopy]

Excellent, thanks.

[styro]

Applied fix to RootFolder.java and it works perfectly. Thanx much!