Feature request: Support of Samsung DLNA abilities

[pygosx]

Can you try this one?

http://rapidshare.com/files/336799291/pms.jar

It works for me !
I can have have subtitles managed by my Samsung UE40B720 without transcoding.
Just hope this patch to be included in the trunk soon.

[pygosx]

I created a diff which enables native Samsung subtitles and seeking.

In DLNAResource.java it disabled encoding for movies with subtitles, if the renderer is Samsung.

In RequestV2.java it adds another GET method like thumbnail0000, just with subtitle0000. For the http header, it adds Captioninfo.sec for the subtitles and sets the right Content-Length aswell, which is needed for seeking.

SeekByTime needs to be set to false in the Samsung.conf, but this should be the default. This patch also enables mkv streaming without transcoding in the Samsung.conf file, which works as long as the audio track is not DTS. If you don't want that just keep your old Samsung.conf.

The attachment samsung.diff.zip is no longer available

Attached Ari's diff file working with r404

[shagrath]

Thanks but does all the Samsung TVs support mkvs ?

[pygosx]

This patch allows UPNP client to request "subtitle0000" method to get subtitles and to not transcode video if a sub file exists.
As described by Samygo http://samygo.sourceforge.net/, most of Samsung TV with UPNP can render subtitles.

But instead of disabling transcoding for all video with subtitles when the renderer is Samsung, what about adding a new parameter SkipTranscodeWhenSubtitled=false|true in the renderer config file?

[shagrath]

Yes, a parameter like this would make sense.

[Pfaeffchen]

Hey guys,

I am new in media server business and (unfortunately) bought a Samsungs TV LE40B750

I tried all you wrote in that threat:
- I installed that pms.jar ari offered
- I changed my samsung.conf to:
MimeTypesChanges=audio/wav=audio/L16|video/x-matroska=video/avi
StreamExtensions=mkv,mp3,mp4,avi

The result:
- I now can play MKV
- The AVI file with subtitles doesn't work anymore (unsupported format).
- Still I am not able to ff or rw.

I am not really sure if PMS recognizes my TV as a Samsung device. I can only see "unknown renderer" at the start screen.

Does someone of you got a hint for me?

Thanks!

[ExSport]

It is possible to enable this "feature" via config so we can test it also on other TV renderers(not Samsung ones)?
Or it is possible to detect automatically if mkv or subtitles are supported and if renderer will answer TRUE,then enable this feature?
Many thanks.

[chewskydoo]

Does this solution still work with the most current beta of PMS (r409)? I have a LN40C650 and am using Ari's updated pms.jar.

MKVs stream successfully (i.e., without transcoding), but I cannot get subtitles to display. My Samsung.conf is:

Code: Select all

# ps3mediaserver renderer profile for Samsung Wiselink
# Refer to PS3.conf for help

RendererName=Samsung LN40C650
RendererIcon=bravia.png
UserAgentSearch=TV-40C650
Video=true
Audio=true
Image=true
SeekByTime=false
TranscodeVideo=MPEGAC3
TranscodeAudio=PCM
DefaultVBVBufSize=true
MuxH264ToMpegTS=true
MuxDTSToMpeg=true
WrapDTSIntoPCM=false
MuxLPCMToMpeg=false
MaxVideoBitrateMbps=0
MaxVideoWidth=0
MaxVideoHeight=0
MimeTypesChanges=audio/wav=audio/L16|video/x-matroska=video/avi
TranscodeExtensions=mov
StreamExtensions=mp3,mp4,avi,mkv

Any ideas on how to fix this? I know I must be doing something wrong, but I'm not sure how to get this to work. Thanks for any and all help!

[ExSport]

I suppose not all Samsung TV support subtitles so beter to define new "magic value" in renderer conf.
Something like adding these lines to RendererConfiguration.java:

Code: Select all

   private static final String SOFT_SUB_SUPPORT="SoftSubSupport";

   public boolean isSoftSubSupport() {
      return getBoolean(SOFT_SUB_SUPPORT, false);
   }

Then it is needed to replace SAMSUNG condition (in attached patch posted here in past)

Code: Select all

-                  if ((forceTranscodeV2 && !skipTranscode) || forceTranscode || (!parserV2 && !child.ext.ps3compatible() && !skipTranscode) || (PMS.getConfiguration().getUseSubtitles() && child.srtFile)) {

+                  if ((forceTranscodeV2 && !skipTranscode) || forceTranscode || (!parserV2 && !child.ext.ps3compatible() && !skipTranscode) || (PMS.getConfiguration().getUseSubtitles() && child.srtFile && !defaultRenderer.isSoftSubSupport())) {

When SoftSubSupport=true is added to renderer conf, it will say to PMS that soft subtitles are supported by renderer.
If not defined or set to FALSE, subtitles are not added to stream when streaming.

[ExSport]

Found bug in this patch.
When you will choose some item from "VIDEO SETTINGS" folder, error will occur.
And now another one:

Code: Select all

output.setHeader("Content-Length", Long.toString(files.get(0).media.size));

This line will break playing transcoded files on PS3(and I suppose also others).
It is because it will change Content-Length also when transcoding!!!
It means when 200MB AVI or MKV is transcoded, 200MB file size is reached much sooner than end of file so it will stop playing file in e.g. 20% of movie...