Latest SVN build discussion

[mazey]

i think its safe to put sb23 into the main build also been running it for awhile no probs, and the main build has been sb22 for over a month.

[SubJunk]

SB24 will be out soon anyway so we will probably skip SB23

[leroy]

i have noticed pmsencoder (1.5.12) is not longer be used as transcode engine with 1.50.2-SB65 / SB66
The engine is loaded, but is not used as default engine, or available with the transcode folder.
i found the problem by testing older builds from Jenkins.

pmsencoder works fine:
5-feb-2012 0:31:26
http://pms.smoeller.de/job/pms%20(trunk)/17/

pmsencoder not longer be used:
5-feb-2012 11:31:26
http://pms.smoeller.de/job/pms%20(trunk)/18/

So i guess next commit is the source of this evil:
https://github.com/ps3mediaserver/ps3mediaserver/commit/309414d7d3909e791b235b4aa07d7f559f232dd2

[Raptor399]

I intended that commit to be backwards compatible (the old methods are marked as deprecated), so plugins like pmsencoder ought to work as before.

Does the logfile say anything useful when pmsencoder doesn't work?

[leroy]

here the logfiles.

pmsencoder work fine: (trunk)/17/

pmsencoder ok logs.zip

(7.22 KiB) Downloaded 45 times

pmsencoder not be used, and not available with the transcode folder:
Instead mencoder web is used as transcode engine. (trunk)/18/

pmsencoder fail logs.zip

(7.62 KiB) Downloaded 41 times

[chocolateboy]

@leroy: thanks for reporting this!

@Raptor399: PMSEncoder modifies (i.e. replaces a Format in) the extensions List returned by PMS.getExtensions():

Code: Select all

def extensions = pms.getExtensions()
extensions.set(0, new WEB()) // i.e. com.chocolatey.pmsencoder.WEB


https://github.com/chocolateboy/pmsenco ... roovy#L134

If this List can no longer be modified in place (e.g. PMS.getExtensions() returns a copy), a) that's fine (see the comment in the link above and here) b) there needs to be a way to (at least) replace or pre-empt a format - in this case the builtin WEB format and c) it's a breaking change.

If it's just the index change (i.e. sorting the formats in alphabetical order, which moves WEB from 0 to 14), then it may or may not be a breaking change (I'm leaning towards it being a bug in PMSEncoder for relying on an implementation detail), but there should still be a sane way for plugins to replace/pre-empt builtin formats and/or add new formats.

If the WEB format is now matched last, it may break matching (i.e. be pre-empted by the extension matchers) for e.g.:

Code: Select all

http://www.example.com/example.mp3
http://www.example.com/example.asf?format=.wmv


&c.

[Raptor399]

Thanks for the thorough analysis, leroy and chocolateboy!
That helped lot.

I have committed two fixes (abc6f15f9 and a2098af9c) that should allow pmsencoder to work as is.

I also added a FormatFactory.setExtensions() in case plugins want to set the complete list of formats.

Let me know if this works!

[chocolateboy]

Yes, it works. Thanks!

[leroy]

Bug is also gone here! PMSEncoder is used again Thanks!

[marco275]

Hi guys,

Just tried to download and build using PMS builder, but with no succes.
Something has changed causing PMS builder to find a video incompatibility of somekind.
See screenshot.

thnx