On Windows, the patch uses winp
to kill a process and all its children (using the killRecursively
method). It's possible that this could be the wrong process if Windows recycles process IDs, but the same would apply with the unpatched code. The only difference on Windows is that with this patch
the child processes are also killed.
I'm more than happy to take out the winp code from the patch, but if this is a recycled process ID issue then removing winp or reverting to the unpatched version won't prevent the unpatched Windows code doing the same thing (albeit with a smaller gun), and, of course, won't fix orphan processes.
I've posted a link to your post on the winp issue tracker