CustomMencoderOptions ignored (on Renderer level)

[ExSport]

I found the bug why from some version until now "CustomMencoderOptions" is ignored.
From older post:

Code: Select all

"CustomMencoderOptions=-vf softskip,expand=::::1:16\/9:4" in Renderer.conf is ignored or replaced so it is not added as MEncoder param.

https://github.com/ps3mediaserver/ps3me ... java#L1419

Code: Select all

if (rendererMencoderOptions.contains("expand=") || dvd) {
   rendererMencoderOptions = null;
}

We should use "&&" instead of "||"

[ExSport]

https://github.com/ps3mediaserver/ps3me ... er/pull/98

[Raptor399]

We should use "&&" instead of "||"

I am not convinced of this, as commented on the pull request.

It appears to be a design choice for PMS to enforce its own "expand=" behavior over that of custom mencoder options.
Personally, I don't know the reasoning behind it, but feel free to challenge that design choice.
Because if that changes, in its wake other pieces of code may need some adjustment as well.