SubJunk wrote:Just tried your patches ExSport and I get a compiling error:
Please post your patched "DLNAResource.java". It works with official trunk, maybe patch applied in wrong way on your subjunk build?
Did you mean to put that WoH #822 code up under if (player == null) {, where the fis variable is used, instead of the else statement?
Code should be like this:
- Code: Select all
if (player == null) {
if (this instanceof IPushOutput) {
PipedOutputStream out = new PipedOutputStream();
PipedInputStream fis = new PipedInputStream(out);
((IPushOutput) this).push(out);
if (low > 0 && fis != null) {
fis.skip(low);
}
// WoH #822
if(high > low && fis != null)
{
long bytes = (high - (low < 0 ? 0 : low)) + 1;
logger.trace("Using size-limiting stream (" + bytes + " bytes)");
SizeLimitInputStream slis = new SizeLimitInputStream(fis, bytes);
return slis;
}
// /WoH #822
return fis;
}
InputStream fis = null;
I removed the bit of code I mentioned in my previous post and it compiled, but then when I tested it, all my MKV files had out of sync audio.
So I reverted the -mc 0.005 part and it was in sync again. So I can't recommend that change.
Very very strange. It should not be due -mc 0.005 parameter. Maybe it is due to wrongly patched file?
Please try to play same file and post used MEncoder command.Also you can try to edit this command by adding -mc 0.005 if it will make file out of sync. -mc 0 and -noskip have to be removed when -mc 0.005 is used.
You can also try my compilation if your files will be out of sync so we will know where is the problem(parameter or bad build).
I never found(never = about 500 files tested) that -mc.005 did something wrong, allways it helped because lot of movies has audio delay set or are wrongly encoded and this helped in all cases. Sure I didn't tested your new mencoder build with it, only with official trunk.
Also you can test my compilation:
http://code.google.com/p/pms-exsport/do ... 1.31.0.exeAlso there is a chance that when I created .patch files I did mistake somewhere, it was quite early morning
Many thanks
ExSport
P.S.
Yes, it seems I forgot to upload messages.properties, I attached it below
Anyway please test my compiled version and if it works then maybe patch doesn't fit without additional changes for your special build or I did mistake when .diff/.patch file was created.
And yes, forced subs should be automatically enabled but I wanted to add it to GUI so normal user can easily enable/disable it without knowing something about conf editing and also will know about this new feature.
But minimally you need gui for setting "forced sub tag and forced sub lang":)
Thx!!!
