Patch for DebugLogPathDefiner.java

[Thibaut]

Hi
I don't where to put little patches, as it's only for linux, I did not try with Windows I put it here.
On my computer, Debian Testing, with pms svn 653, the debug file can't be created in the tmp dir because it tries to create the file /tmpdebug.log
here is my patch:

Code: Select all

--- net/pms/logging/DebugLogPathDefiner.java   (revision 653)
+++ net/pms/logging/DebugLogPathDefiner.java   (working copy)
@@ -59,7 +59,7 @@
       }
 
       // Return path to temp folder, which should be writeable
-      return System.getProperty("java.io.tmpdir");
+      return System.getProperty("java.io.tmpdir")+'/';
    }
 
 }


[meskibob]

Moved to Dev thread.

[Raptor399]

That patch might work for the posters situation, but from the looks of it needs to be more generic to be included in PMS.

[chocolateboy]

@Raptor399: Indeed: right idea, wrong file.

@Thibaut. Thanks. This should be fixed (in logback.xml) in r654.

[Thibaut]

Hi
Sorry to be a bit picky but your solution is not working totally.
If I don't have the write rights in the working directory, the debug.log file is created in the temp directory. That's good.
But if I have the write rights in the working directory, it will try to write in /debug.log (linux) and it can't write the file here.
Maybe the problem is more the path return in that case which is "" and put the absolute path instead.

Code: Select all

--- net/pms/logging/DebugLogPathDefiner.java   (revision 657)
+++ net/pms/logging/DebugLogPathDefiner.java   (working copy)
@@ -52,7 +52,7 @@
          file.createNewFile();
          if (file.canWrite()) {
             file.delete();
-            return "";
+            return System.getProperty("user.dir");
          }
       } catch (Exception e) {
          // Could not create / write the file


[chocolateboy]

Thanks. Try r658.